Conversation
…模型遗漏该参数 (issue_moizl31y_hagnn4)
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Member
Author
Attribution post-PR evaluation
Cases
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribution issue
Automation summary
managePermissionstool schema,password(andusername) were declared asz.string().optional()without any description indicating they are required for thecreateUseraction. The runtime code correctly validates both parameters, but the model only sees the schema — which marks them optional with no hint about action-specific requirements. This caused the model to omitpasswordwhen callingcreateUser, resulting in the API error "缺少必填参数 username 和 password"..describe()to bothusernameandpasswordfields in themanagePermissionstool'sinputSchemaatmcp/src/tools/permissions.ts:595-596, explicitly stating they are required foraction=createUser. This is a Layer 1 (cheapest) fix — the schema still allows these fields to be optional (since they ARE optional for other actions likeupdateUser), but now the model is informed via the description thatcreateUserrequires them.tsc --noEmit), all 3 required skill quality tests pass (build-skills-repo,build-compat-config,skill-quality-standards).Changed files
mcp/src/tools/permissions.ts