Skip to content

fix: managePermissions工具createUser动作未将password声明为必填参数,导致模型遗漏该参数#646

Open
binggg wants to merge 1 commit intomainfrom
automation/attribution-issue-moizl31y-hagnn4-managepermissions-createuser-password-moj1w4jl
Open

fix: managePermissions工具createUser动作未将password声明为必填参数,导致模型遗漏该参数#646
binggg wants to merge 1 commit intomainfrom
automation/attribution-issue-moizl31y-hagnn4-managepermissions-createuser-password-moj1w4jl

Conversation

@binggg
Copy link
Copy Markdown
Member

@binggg binggg commented Apr 28, 2026

Attribution issue

  • issueId: issue_moizl31y_hagnn4
  • category: tool
  • canonicalTitle: managePermissions工具createUser动作未将password声明为必填参数,导致模型遗漏该参数
  • representativeRun: atomic-js-cloudbase-cli-user-create/2026-04-28T18-54-24-ba89b0

Automation summary

  • root_cause: In managePermissions tool schema, password (and username) were declared as z.string().optional() without any description indicating they are required for the createUser action. The runtime code correctly validates both parameters, but the model only sees the schema — which marks them optional with no hint about action-specific requirements. This caused the model to omit password when calling createUser, resulting in the API error "缺少必填参数 username 和 password".
  • changes: Added .describe() to both username and password fields in the managePermissions tool's inputSchema at mcp/src/tools/permissions.ts:595-596, explicitly stating they are required for action=createUser. This is a Layer 1 (cheapest) fix — the schema still allows these fields to be optional (since they ARE optional for other actions like updateUser), but now the model is informed via the description that createUser requires them.
  • validation: TypeScript compilation passes (tsc --noEmit), all 3 required skill quality tests pass (build-skills-repo, build-compat-config, skill-quality-standards).
  • follow_up: None. The fix is minimal and targeted — only the two parameter

Changed files

  • mcp/src/tools/permissions.ts

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@binggg
Copy link
Copy Markdown
Member Author

binggg commented Apr 28, 2026

Attribution post-PR evaluation

  • visibility: internal identifiers, run ids, and private links are intentionally omitted
  • attempt: 1
  • eval_scope: primary_only
  • overall: FAILED
  • summary: at least one planned evaluation case failed
  • updated_at: 2026-04-28T20:06:53.424Z

Cases

  • [FAILED] — primary — evaluation failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant