fix: pass site_prefix to CloudFront module#66
Open
blimmer wants to merge 2 commits intoTechToSpeech:release/0.2.0from
Open
fix: pass site_prefix to CloudFront module#66blimmer wants to merge 2 commits intoTechToSpeech:release/0.2.0from
blimmer wants to merge 2 commits intoTechToSpeech:release/0.2.0from
Conversation
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
main.tfto pass thesite_prefixvariable to the CloudFront module. The module references the site prefix when creating the Wordpress bucket:terraform-aws-serverless-static-wordpress/modules/cloudfront/distribution.tf
Lines 4 to 5 in abc903d
However,
site_prefixwas not passed from the main module instantiation to the submodule. For me, this caused an error because I already had an S3 bucket with thewww.<site_domain>.comcreated.wwwis the variable default defined here:terraform-aws-serverless-static-wordpress/modules/cloudfront/variables.tf
Lines 6 to 10 in abc903d
By passing through the site prefix, with this PR, I was able to get past the error and create the bucket
<custom_site_prefix>.<site_domain>.com.