[TASK] Add regression test for the mobile search-toggle fix - #1411
Merged
linawolf merged 1 commit intoSep 12, 2026
Merged
Conversation
TYPO3-Documentation#1391 fixed #search-toggle opening a dead-end panel instead of the search dialog. Add a guard so it can't silently regress a second time: covers both entry points into SearchModal, the mobile #search-toggle (forwarded via menu-expandable.js) and GlobalSearch's own desktop button, asserting each opens the dialog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1391 fixed #search-toggle opening a dead-end panel instead of the search dialog. Add a guard so it can't silently regress a second time: covers both entry points into SearchModal, the mobile #search-toggle (forwarded via menu-expandable.js) and GlobalSearch's own desktop button, asserting each opens the dialog.