[BUGFIX] Guard the search scope select against a missing page header - #1408
Open
linawolf wants to merge 1 commit into
Open
[BUGFIX] Guard the search scope select against a missing page header#1408linawolf wants to merge 1 commit into
linawolf wants to merge 1 commit into
Conversation
search-form.js added a "Search current" option to #searchscope after checking the URL but not the DOM, so add() dereferenced null when the element was absent, and the uncaught error aborted the remaining page scripts. Same guard CybotTM applied to versions.js in #1361. Not reachable on docs.typo3.org, whose page header always renders the select — but reachable since #1190 made templates overridable. Errors thrown inside a listener never reach the dispatchEvent caller, so both regression tests listen for the window error event. The test from guard removed; it now fails. Signed-off-by: lina.wolf Assisted-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019EuSAzF5qw81NzPusWy2hC
linawolf
force-pushed
the
task/guard-search-form-selector
branch
from
September 11, 2026 20:01
4fb417a to
b9c7aaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BUGFIX] Guard the search scope select against a missing page header
search-form.js added a "Search current" option to #searchscope after
checking the URL but not the DOM, so add() dereferenced null when the
element was absent, and the uncaught error aborted the remaining page
scripts. Same guard CybotTM applied to versions.js in #1361.
Not reachable on docs.typo3.org, whose page header always renders the
select — but reachable since #1190 made templates overridable.
Errors thrown inside a listener never reach the dispatchEvent caller, so
both regression tests listen for the window error event. The test from
#1361 asserted dispatchEvent did not throw, which stayed green with the
guard removed; it now fails.