fix: chunk unload bug present in vanilla#110
Open
umbrageodotus wants to merge 1 commit intoRelativityMC:ver/1.21.11from
Open
fix: chunk unload bug present in vanilla#110umbrageodotus wants to merge 1 commit intoRelativityMC:ver/1.21.11from
umbrageodotus wants to merge 1 commit intoRelativityMC:ver/1.21.11from
Conversation
Explanation of the bug: Clients (correctly) ignore all chunk unload packets outside view distance. The server was sending the view distance center packet before the chunk unloads. Together, that means unloads were now happening outside the view distance (calculated with the center coming from that packet), which in turn led them to not be unloaded. This fixes issues with sodium (I reckon this is the cause for the 30s loads on some servers) and fixes chunk caching and bugs related to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of the bug:
Clients (correctly) ignore all chunk unload packets outside view distance. The server was sending the view distance center packet before the chunk unloads. Together, that means unloads were now happening outside the view distance (calculated with the center coming from that packet), which in turn led them to not be unloaded. This fixes issues with sodium (I reckon this is the cause for the 30s loads on some servers) and fixes chunk caching and bugs related to it.