Fix: weibull default space - #307
Open
docxology wants to merge 3 commits into
Open
Conversation
- getlogpartition: return scalar k*log(λ) - log(k) (was wrong-valued 1-vector k/λ) - getgradlogpartition: use closure arg λ (was undefined η1); correct to k/λ
Assert the default-space log-partition is a scalar equal to natural-space (k·log λ − log k) and the gradient no longer crashes, matching ForwardDiff. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
Confirmed. The default gradient referenced an undefined |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
+ Coverage 83.91% 84.06% +0.14%
==========================================
Files 45 45
Lines 4078 4078
==========================================
+ Hits 3422 3428 +6
+ Misses 656 650 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Verified audit fix] — branch
fix/weibull-default-space.Commit:
fix(Weibull): repair DefaultParametersSpace helpersChanges
src/distributions/weibull.jl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Verification
Confirmed against
mainin the ReactiveBayes audit (Julia 1.12.6); sources verified read-only. See the branch diff.