make translation folder relative to plugins folder#18051
Open
qurious-pixel wants to merge 4 commits intoRPCS3:masterfrom
Open
make translation folder relative to plugins folder#18051qurious-pixel wants to merge 4 commits intoRPCS3:masterfrom
qurious-pixel wants to merge 4 commits intoRPCS3:masterfrom
Conversation
Contributor
|
Why? |
Contributor
Author
|
Gives a point of reference to find the translation folders against all builds. It was hardcoded, which led to the differences in trying to find the files, especially in Windows. MSVC: looks in <root_folder>/qt6/translations Since plugin dir is known at all times, translations will be located in the same subdirectory. EDIT: hardcoded to the path of the dev build runner. |
Contributor
|
I don't think this is the correct approach |
Contributor
Author
|
alternate approach, modify the builders path: After cmake configures, but before it builds (because of the post-processing; windeployqt) |
Contributor
|
I'll check it out sometime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.