Skip to content

make translation folder relative to plugins folder#18051

Open
qurious-pixel wants to merge 4 commits intoRPCS3:masterfrom
qurious-pixel:patch-3
Open

make translation folder relative to plugins folder#18051
qurious-pixel wants to merge 4 commits intoRPCS3:masterfrom
qurious-pixel:patch-3

Conversation

@qurious-pixel
Copy link
Copy Markdown
Contributor

No description provided.

@Megamouse
Copy link
Copy Markdown
Contributor

Why?

@qurious-pixel
Copy link
Copy Markdown
Contributor Author

qurious-pixel commented Jan 14, 2026

Gives a point of reference to find the translation folders against all builds. It was hardcoded, which led to the differences in trying to find the files, especially in Windows.

MSVC: looks in <root_folder>/qt6/translations
Clang: looks in <root_folder>/share/qt6/translations
Clang-CL: looks in <root_folder>/translations/Qt6

Since plugin dir is known at all times, translations will be located in the same subdirectory.

EDIT: hardcoded to the path of the dev build runner.

@Megamouse
Copy link
Copy Markdown
Contributor

I don't think this is the correct approach

@qurious-pixel
Copy link
Copy Markdown
Contributor Author

alternate approach, modify the builders path:

set -x
# Qt6 translations on Clang-cl build
mkdir -p "$VcpkgInstall"/Qt6/translations/
ls -al "$VcpkgInstall"
ls -al "$VcpkgInstall"/tools/Qt6/bin
sed -i '0,/Translations=translations\/Qt6\//s|Translations=translations/Qt6/|Translations=Qt6/translations/|' "$VcpkgInstall"/tools/Qt6/bin/qt.conf
cat "$VcpkgInstall"/tools/Qt6/bin/qt.conf
cp "$VcpkgInstall"/translations/Qt6/* "$VcpkgInstall"/Qt6/translations/
"$VcpkgInstall"/tools/Qt6/bin/qmake -query QT_INSTALL_TRANSLATIONS
set +x

After cmake configures, but before it builds (because of the post-processing; windeployqt)

@Megamouse Megamouse added the Localization Anything that involves translating the GUI label Jan 14, 2026
@Megamouse
Copy link
Copy Markdown
Contributor

I'll check it out sometime

@Megamouse Megamouse added the Build and CI Anything related to the build process and continuous integration label Feb 28, 2026
@AniLeo AniLeo requested a review from Megamouse April 15, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build and CI Anything related to the build process and continuous integration Localization Anything that involves translating the GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants