Add page-16 sliding-window attention support - #1055
Draft
zjing14 wants to merge 4 commits into
Draft
Conversation
added 4 commits
August 21, 2026 12:36
# Conflicts: # kernels/attention/flash_attn_interface.py # kernels/attention/flash_attn_utils.py # tests/kernels/test_flash_attn_fwd.py
Hoist the FP8 V-tile LDS address calculation out of repeated loads in the gfx950 dual-wave FlashAttention loop. Preserve the existing load path for non-FP8 PV configurations.
Reverse the q-block launch order for the dense gfx950 BF16 GQA causal configuration so longer-running blocks issue first. Enable the optimized path from sequence length 256 while retaining the existing guards for unsupported modes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extend FlyDSL paged attention for SBD-style short-query workloads:
kernelsmodules in wheels and source distributions.The existing dual-wave path remains page-size-64 only. Page-size-16 and sliding-window workloads use the short-query generic path.
Testing