feat: improve codegen testing and add verify target#189
feat: improve codegen testing and add verify target#189
Conversation
- Add `make verify` for fast local validation suite - Add AGENTS.md with repository guidelines for AI assistants - Fix rust_writer.py: check for existing `impl Solution` before generating - Refactor test_code_generation.py: align with dev snippet fixture, add design problem test
785abd3 to
3f11add
Compare
- Add `make health` target for checking problem folder health - Add repository_health.py: scan for missing docs, testcases, broken links, Rust workspace drift - Add test_repository_health.py: unit tests for health checks - Update leetcode.py: add health check menu option (10) - Add sync_rust_cargo_main: auto-sync Cargo.toml with Rust solution packages - Update Cargo.toml: add new Rust problem packages, remove stale entries
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 382795e98b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if path_match and not (root_path / path_match.group(1)).exists(): | ||
| removed_paths.append(path_match.group(1)) | ||
| continue |
There was a problem hiding this comment.
Preserve other members when removing stale Cargo paths
The stale-entry cleanup in sync_rust_cargo_main deletes the entire line whenever it finds a missing "problems/..." path, which corrupts valid workspace config if multiple members share one line (for example members = ["rust/library", "problems/problems_999"]). In that case, removing the stale problem path also drops rust/library, so subsequent Cargo commands lose required workspace crates and can fail.
Useful? React with 👍 / 👎.
Summary
make verifyfor fast local validation (unit tests, TypeScript smoke, Go libs)AGENTS.mdwith repository guidelines for AI assistantsrust_writer.py: check for existingimpl Solutionbefore generating struct-based solutiontest_code_generation.py: align with dev snippet fixture, add design problem test caseTest plan
make verifypasses locallymake testpasses🤖 Generated with Claude Code