Skip to content

Rename bindgen-c to bindgen-cli#16096

Open
jakelishman wants to merge 1 commit intoQiskit:mainfrom
jakelishman:c/bindgen-cli-rename
Open

Rename bindgen-c to bindgen-cli#16096
jakelishman wants to merge 1 commit intoQiskit:mainfrom
jakelishman:c/bindgen-cli-rename

Conversation

@jakelishman
Copy link
Copy Markdown
Member

This name is rather clearer, and makes more sense as we expand the capabilities the tool can drive.

Built on #15778, and that PR (now I come back to it) is the initial motivation for the rename.

AI/LLM disclosure

  • I didn't use LLM tooling, or only used it privately.
  • I used the following tool to help write this PR description:
  • I used the following tool to generate or modify code:

@jakelishman jakelishman added this to the 2.5.0 milestone Apr 28, 2026
@jakelishman jakelishman requested a review from a team as a code owner April 28, 2026 10:26
@jakelishman jakelishman added on hold Can not fix yet Changelog: Build Add a "Build System" entry in the GitHub Release changelog. labels Apr 28, 2026
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 28, 2026

Coverage Report for CI Build 25100513212

Coverage increased (+0.01%) to 87.504%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 3 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

3 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
crates/qasm2/src/lex.rs 2 92.8%
crates/circuit/src/parameter/parameter_expression.rs 1 90.53%

Coverage Stats

Coverage Status
Relevant Lines: 120034
Covered Lines: 105034
Line Coverage: 87.5%
Coverage Strength: 977310.14 hits per line

💛 - Coveralls

This name is rather clearer, and makes more sense as we expand the
capabilities the tool can drive.
@jakelishman jakelishman force-pushed the c/bindgen-cli-rename branch from f6a4784 to 8aa7b3c Compare April 29, 2026 09:12
@jakelishman jakelishman removed the on hold Can not fix yet label Apr 29, 2026
@jakelishman jakelishman marked this pull request as draft April 30, 2026 15:12
@jakelishman jakelishman marked this pull request as ready for review April 30, 2026 15:12
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: Build Add a "Build System" entry in the GitHub Release changelog.

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

3 participants