Skip to content

Better separation of CircuitData and PyCircuitData#16095

Draft
gadial wants to merge 5 commits intoQiskit:mainfrom
gadial:py_circuit_data_params_handling
Draft

Better separation of CircuitData and PyCircuitData#16095
gadial wants to merge 5 commits intoQiskit:mainfrom
gadial:py_circuit_data_params_handling

Conversation

@gadial
Copy link
Copy Markdown
Contributor

@gadial gadial commented Apr 28, 2026

AI/LLM disclosure

  • I didn't use LLM tooling, or only used it privately.
  • I used the following tool to help write this PR description:
  • I used the following tool to generate or modify code:

@coveralls
Copy link
Copy Markdown

coveralls commented Apr 28, 2026

Coverage Report for CI Build 25154093382

Coverage increased (+0.008%) to 87.578%

Details

  • Coverage increased (+0.008%) from the base build.
  • Patch coverage: 12 uncovered changes across 2 files (107 of 119 lines covered, 89.92%).
  • 12 coverage regressions across 5 files.

Uncovered Changes

File Changed Covered %
crates/circuit/src/circuit_data.rs 93 82 88.17%
crates/qpy/src/circuit_reader.rs 20 19 95.0%

Coverage Regressions

12 previously-covered lines in 5 files lost coverage.

File Lines Losing Coverage Coverage
crates/circuit/src/parameter/symbol_expr.rs 4 73.8%
crates/qasm2/src/lex.rs 4 92.29%
crates/circuit/src/circuit_data.rs 2 87.21%
crates/circuit/src/parameter/parameter_expression.rs 1 90.53%
crates/qpy/src/circuit_reader.rs 1 78.88%

Coverage Stats

Coverage Status
Relevant Lines: 121286
Covered Lines: 106220
Line Coverage: 87.58%
Coverage Strength: 969405.1 hits per line

💛 - Coveralls

@raynelfss raynelfss self-assigned this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants