Fix UGate OpenQASM 3 phase note#16079
Open
TSS99 wants to merge 1 commit intoQiskit:mainfrom
Open
Conversation
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct the
UGatedocstring note that compares Qiskit's matrix convention with the current OpenQASM 3Udefinition.Fixes #15830.
Problem
The existing note says Qiskit's displayed
UGatematrix is the same as OpenQASM 3. The current OpenQASM 3 specification definesUwith an additional global phase relative to Qiskit's matrix.Root cause
The docstring appears to describe an older OpenQASM 3 convention. The live OpenQASM 3 specification now defines
U(theta, phi, lambda)as Qiskit's matrix multiplied byexp(i * theta / 2).Fix
Update the note to state the current OpenQASM 3 global-phase relationship, while preserving the existing note about earlier OpenQASM definitions.
Tests
.venv/bin/python -m black --check qiskit/circuit/library/standard_gates/u.py.venv/bin/python -m ruff check qiskit/circuit/library/standard_gates/u.pyexp(i * theta / 2)times Qiskit'sUGatematrix for sampled parameters.Notes / limitations
This is a documentation-only correction; no runtime behavior changes.
AI/LLM disclosure