Skip to content

PHP 7.4, 8.3 + 8.5 polyfills: update the rulesets / sync with v1.4x.x #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrfnl merged 1 commit into from
Jul 6, 2026
Merged

PHP 7.4, 8.3 + 8.5 polyfills: update the rulesets / sync with v1.4x.x #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions PHPCompatibilitySymfonyPolyfillPHP74/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,9 @@
<exclude-pattern>/polyfill[_-]php74/Php74\.php$</exclude-pattern>
</rule>

<!-- Version toggle present. See: https://github.com/symfony/polyfill/pull/640 -->
<rule ref="PHPCompatibility.Classes.NewClasses.valueerrorFound">
<exclude-pattern>/polyfill[_-]php74/Php74\.php$</exclude-pattern>
</rule>

</ruleset>
9 changes: 4 additions & 5 deletions PHPCompatibilitySymfonyPolyfillPHP83/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
<exclude name="PHPCompatibility.FunctionUse.NewFunctions.ldap_exop_syncFound"/>
<exclude name="PHPCompatibility.FunctionUse.NewFunctions.ldap_connect_walletFound"/>

<!-- This is a PHP 8.0 feature, but is polyfilled in the PHP 8.3 package to polyfill certain PHP 8.3 features properly. -->
<!-- See: https://github.com/symfony/polyfill/pull/637 -->
<exclude name="PHPCompatibility.Classes.NewClasses.valueerrorFound"/>

<!-- https://github.com/symfony/polyfill-php83/tree/1.x/Resources/stubs -->
<!--
Detection for the Override attribute is incomplete in PHPCompatibility 10.0.0-alpha1.
Expand Down Expand Up @@ -79,11 +83,6 @@
<exclude-pattern>/polyfill-php83/bootstrap81\.php$</exclude-pattern>
</rule>

<!-- Version toggle present. See: https://github.com/symfony/polyfill/pull/501 -->
<rule ref="PHPCompatibility.Classes.NewClasses.valueerrorFound">
<exclude-pattern>/polyfill-php83/Php83\.php$</exclude-pattern>
</rule>

<!-- See: https://github.com/symfony/polyfill/pull/594 -->
<rule ref="PHPCompatibility.FunctionUse.NewFunctionParameters.ldap_exop_controlsFound">
<exclude-pattern>/polyfill-php83/bootstrap\.php$</exclude-pattern>
Expand Down
13 changes: 4 additions & 9 deletions PHPCompatibilitySymfonyPolyfillPHP85/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
<exclude name="PHPCompatibility.FunctionUse.NewFunctions.locale_is_right_to_leftFound"/>
<exclude name="PHPCompatibility.FunctionUse.NewFunctions.grapheme_levenshteinFound"/>

<!-- This is a PHP 8.0 feature, but is polyfilled in the PHP 8.3 package to polyfill certain PHP 8.3 features properly. -->
<!-- See: https://github.com/symfony/polyfill/pull/637 -->
<exclude name="PHPCompatibility.Classes.NewClasses.valueerrorFound"/>

<!-- https://github.com/symfony/polyfill-php85/tree/1.x/Resources/stubs -->
<!--
Detection for the DelayedTargetValidation and NoDiscard attributes is incomplete in PHPCompatibility 10.0.0-alpha1.
Expand Down Expand Up @@ -48,13 +52,4 @@
<exclude-pattern>/polyfill-php85/bootstrap80\.php$</exclude-pattern>
</rule>

<!--
Not a false positive, but a bug in the Symfony PHP 8.5 polyfill package.
Bug has been reported: ...
Temporarily silencing the error as this needs to be solved upstream.
-->
<rule ref="PHPCompatibility.Classes.NewClasses.valueerrorFound">
<exclude-pattern>/polyfill-php85/Php85\.php$</exclude-pattern>
</rule>

</ruleset>
2 changes: 2 additions & 0 deletions Test/SymfonyPolyfillPHP83Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,5 @@ class Foo extends DateError {}
} catch (DateObjectError | DateRangeError $e) {
} catch (SQLite3Exception $e) {
}

throw new ValueError();
2 changes: 2 additions & 0 deletions Test/SymfonyPolyfillPHP85Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@ function dummy() {}

locale_is_right_to_left($locale);
grapheme_levenshtein( $s1, $s2 );

throw new ValueError();
Loading