Feature/conformal thin panel pec and sgbc - #240
Open
Alberto-o wants to merge 50 commits into
Open
Conversation
…. Adds placeholder json
… to separate construction of volumes and surfaces
…rface. At this point they are equivalent
- Updated the triangles in conformal.fdtd.json for better clarity and organization. - Introduced a new input example conformal_cell_label.fdtd.json with a basic cell structure. - Added another input example mixed_sign_surface_interval.fdtd.json demonstrating a mixed sign surface interval.
lmdiazangulo
requested changes
Aug 17, 2026
Contributor
There was a problem hiding this comment.
This file contains modifications which are quite trivial (spaces between types). I would prefer them to not be here and in case of doubt, adhere to #283
| type(cell_region_t) :: cR | ||
| logical :: foundConformalEntry | ||
|
|
||
| call this%core%get(je, J_CONF_VOLUME_TRIANGLES, conformalEntry, found=foundConformalEntry) |
Contributor
There was a problem hiding this comment.
Why are conformal references inside the CELL path? It should be separated from the CONFORMAL label path.
Contributor
There was a problem hiding this comment.
Same as for cell_map.f90. Adhere to style convention if necessary but do not change stylistic stuff unnecesarily.
- Standardized indentation and spacing throughout the file. - Updated type definitions for clarity, specifically changing `XYZlimit_t_scaled` to `XYZlimit_scaled_t`. - Ensured consistent use of `intent` attributes in subroutine definitions. - Improved readability by aligning comments and code blocks. - Removed unnecessary comments and cleaned up commented-out code sections.
- Adjusted comments for consistency in `conformal_surface_sphere_prepost.py` and `conformal_thin_strip_prepost.py`. - Removed unnecessary blank lines in JSON configuration files `pw-with-periodic.fdtd.json` and `conformal.fdtd.json`. - Ensured consistent spacing in material definitions within `conformal.fdtd.json`.
lmdiazangulo
approved these changes
Aug 21, 2026
lmdiazangulo
marked this pull request as ready for review
August 27, 2026 08:04
adrianarce-elemwave
removed their request for review
August 28, 2026 07:12
lmdiazangulo
requested changes
Aug 28, 2026
lmdiazangulo
left a comment
lmdiazangulo
left a comment
Contributor
There was a problem hiding this comment.
Problems when conformal contain intervals formed by lines.
Contributor
|
Some extra design comments on conformal.
|
…ate face properties
- Updated the Solver module to include conformal SGBC state handling. - Introduced new types and variables for conformal SGBC in the timestepping module. - Implemented logic for advancing conformal SGBC states during solver iterations. - Added tests for conformal SGBC functionality, including zero state, layer orientation, geometry winding, and rejection of unsplit geometry. - Enhanced JSON parser to read conformal SGBC materials and validate their properties. - Created a sample JSON input file for testing conformal SGBC materials. - Updated CMake and test files to include new tests and dependencies.
- Removed the predefined excitation file `predefinedExcitation.1.exc`. - Updated `solenoid.fdtd.json`, `solenoid_45deg_with_conformal.fdtd.json`, and `solenoid_45deg_with_staircased.fdtd.json`: - Increased `numberOfSteps` from 26 to 32. - Changed terminal name from "terminal_50ohm" to "terminal_25ohm". - Adjusted resistance from 50.0 to 25.0 in terminal configurations. - Replaced `magnitudeFile` from `predefinedExcitation.1.exc` to `gauss.exc` for the generator source.
lmdiazangulo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.