Add official aarch64 release builds to deploy workflow#463
Open
permafrost06 wants to merge 4 commits intoOpenBangla:developfrom
Open
Add official aarch64 release builds to deploy workflow#463permafrost06 wants to merge 4 commits intoOpenBangla:developfrom
permafrost06 wants to merge 4 commits intoOpenBangla:developfrom
Conversation
The package filename was being set before CPACK_PACKAGE_NAME was defined, resulting in packages named for example '_3.0.0-distro.rpm' instead of 'ibus-openbangla_3.0.0-distro.rpm'.
QWindow::startSystemMove() was added in Qt 5.15, but Ubuntu 20.04 ships with Qt 5.12. Use preprocessor check to conditionally compile this code.
mominul
requested changes
May 2, 2026
Member
mominul
left a comment
mominul
left a comment
There was a problem hiding this comment.
Thanks! Let's deduplicate the platform code.
mominul
requested changes
May 4, 2026
| ui->buttonIcon->setCursor(Qt::ArrowCursor); | ||
| } else if(this->windowHandle()->startSystemMove()){ | ||
| } | ||
| #if QT_VERSION >= QT_VERSION_CHECK(5, 15, 0) |
Member
There was a problem hiding this comment.
We now hard depend on Qt 5.15, so lets remove this check and remove the builders that don't have 5.15
| runs-on: ${{ matrix.platform }} | ||
| container: | ||
| image: ${{ matrix.container }} | ||
| image: ${{ matrix.platform == 'ubuntu-24.04-arm' && format('arm64v8/{0}', matrix.container) || matrix.container }} |
Member
There was a problem hiding this comment.
Why do we need to specify arm64v8 explicitly? Isn't it the default that if the host platform is arm64 the docker images will be automatically arm64 based?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds official aarch64 release builds to the deploy workflow so ARM64 users can download prebuilt artifacts instead of building from source.
I've split x86_64 and aarch64 into separate jobs.
I also had to add two commits to fix issues: one for broken package filenames caused by
CPACK_PACKAGE_FILE_NAMEbeing set beforeCPACK_PACKAGE_NAME, and one for a Qt 5.15+ API used on older Qt versions in CI. I am not very experienced in this area, so please review those two fixes. Please also provide feedback on if the code fits the style of this codebase (e.g. using macros to determine qt version).The built packages can be seen here in a workflow run.
EDIT: I've only tested the fedora 41 package on Fedora Asahi Remix (Apple M1)
Fixes #461
Fixes #408