Fix #456: Localize export-to-text placeholders with German translations and E2E test#476
Closed
iclectic wants to merge 1 commit intoNeoCoderMatrix86:developmentfrom
iclectic:localize-export-placeholders-v2
Closed
Fix #456: Localize export-to-text placeholders with German translations and E2E test#476iclectic wants to merge 1 commit intoNeoCoderMatrix86:developmentfrom iclectic:localize-export-placeholders-v2
iclectic wants to merge 1 commit intoNeoCoderMatrix86:developmentfrom
iclectic:localize-export-placeholders-v2
Conversation
…nd E2E test - Updated GenerateExportDialog.razor to use plain localization keys (Artist, Title, Album, etc.) without 'Placeholder_' prefix - Added German translations in GenerateExportDialog.de.resx for placeholder names - Added Title attributes to MudMenuItem components for tooltips showing both localized names and placeholder values - Extended ChangeLanguageAsync E2E test to verify German localization of export placeholder dropdown labels - Resolves issue #456 by making export placeholder names user-friendly and localized
| exportOptions.SelectedExportProfile.SchemeHead += placeholder.Value; | ||
| } | ||
| }"> | ||
| }" |
Owner
There was a problem hiding this comment.
Title is not allowed in MudBlazor!
| <data name="Placeholder_Artist" xml:space="preserve"> | ||
| <value>Künstler</value> | ||
| </data> | ||
| <data name="Placeholder_Title" xml:space="preserve"> |
Owner
There was a problem hiding this comment.
Please do NOT use Placeholder_
| <data name="Performer" xml:space="preserve"> | ||
| <value>Performer</value> | ||
| </data> | ||
| <data name="Placeholder_Artist" xml:space="preserve"> |
Owner
There was a problem hiding this comment.
Please do NOT use Placeholder_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue #456 by fully localizing the export-to-text placeholders in the export dialog.