Proposed fix - "Fix #456: Localize export-to-text placeholders and ad…#471
Closed
iclectic wants to merge 0 commit intoNeoCoderMatrix86:developmentfrom
iclectic:feature-branch
Closed
Proposed fix - "Fix #456: Localize export-to-text placeholders and ad…#471iclectic wants to merge 0 commit intoNeoCoderMatrix86:developmentfrom iclectic:feature-branch
iclectic wants to merge 0 commit intoNeoCoderMatrix86:developmentfrom
iclectic:feature-branch
Conversation
| <MudMenuItem | ||
| OnClick="() => InsertCuesheetPlaceholder(placeholder.Value)" | ||
| Title="@(_localizer["Placeholder_"+placeholder.Key] + " (" + placeholder.Value + ")")"> | ||
| @_localizer["Placeholder_" + placeholder.Key] |
Owner
There was a problem hiding this comment.
Please just localize the placeholder without the preffix "Placeholder_", like for example "Artist" instead of "Placeholder_Artist".
| void InsertTrackPlaceholder(string token) | ||
| { | ||
| if (exportOptions?.SelectedExportProfile != null) | ||
| exportOptions.SelectedExportProfile.SchemeTracks += token; |
Owner
There was a problem hiding this comment.
Suggested change
| exportOptions.SelectedExportProfile.SchemeTracks += token; | |
| { | |
| exportOptions.SelectedExportProfile.SchemeTracks += token; | |
| } |
| void InsertCuesheetPlaceholder(string token) | ||
| { | ||
| if (exportOptions?.SelectedExportProfile != null) | ||
| exportOptions.SelectedExportProfile.SchemeHead += token; |
Owner
There was a problem hiding this comment.
Suggested change
| exportOptions.SelectedExportProfile.SchemeHead += token; | |
| { | |
| exportOptions.SelectedExportProfile.SchemeHead += token; | |
| } |
Owner
|
Please also add an End2End Test inside the AudioCuesheetEditor.End2EndTests Project IndexTests.cs, maybe inside the ChangeLanguageAsync Test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456: Localize export-to-text placeholders