CCM-13367: Allocation Logic#540
Open
nhsd-david-wass wants to merge 24 commits intomainfrom
Open
Conversation
nhsd-david-wass
force-pushed
the
feature/CCM-13382-Calculate-Supplier-Weighting
branch
12 times, most recently
from
3ced052 to
c4e3fdd
Compare
nhsd-david-wass
force-pushed
the
feature/CCM-13382-Calculate-Supplier-Weighting
branch
2 times, most recently
from
56b6185 to
412e133
Compare
masl2
changed the title
nhsd-david-wass
force-pushed
the
feature/CCM-13382-Calculate-Supplier-Weighting
branch
10 times, most recently
from
2906361 to
23be770
Compare
stevebux
reviewed
Apr 29, 2026
Contributor
stevebux
left a comment
stevebux
left a comment
There was a problem hiding this comment.
Looks great, just a few minor comments
| "dynamodb:Query" | ||
| "dynamodb:Query", | ||
| "dynamodb:PutItem", | ||
| "dynamodb:UpdateItem" |
Contributor
There was a problem hiding this comment.
Is it worth making the permissions more granular here? You probably don't need write access to the supplier config table, I would have thought
| suppliers: Supplier[], | ||
| deps: Deps, | ||
| ): Promise<Supplier[]> { | ||
| const dailyAllocationDate = new Date().toISOString().split("T")[0]; // Get current date in YYYY-MM-DD format |
Contributor
There was a problem hiding this comment.
This should probably use the Europe/London time zone to avoid out-by-one-hour errors in BST. The core repo uses date-fns as a lightweight way of getting support for time zones.
| supplierFactors, | ||
| }); | ||
| let selectedSupplierId = supplierFactors[0].supplierId; | ||
| let lowestFactor = supplierFactors[0].factor; |
Contributor
There was a problem hiding this comment.
Is there any chance supplierFactors could be an empty array at this point?
nhsd-david-wass
force-pushed
the
feature/CCM-13382-Calculate-Supplier-Weighting
branch
from
a5eb228 to
e4aad0d
Compare
stevebux
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
DT3-Specific Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.