Skip to content

CCM-16439: Bucket Expiry Policies #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScottFullerton-NHSE wants to merge 2 commits into
base: main
Choose a base branch
from
+20 −2
Open

CCM-16439: Bucket Expiry Policies #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b296285
CCM-16439: Initial commit
ScottFullerton-NHSE Apr 27, 2026
4d44402
CCM-16439: Fix deploy error
ScottFullerton-NHSE Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion infrastructure/terraform/components/dl/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ No requirements.
| <a name="input_metadata_refresh_schedule"></a> [metadata\_refresh\_schedule](#input\_metadata\_refresh\_schedule) | Schedule for refreshing reporting metadata. | `string` | `"cron(10 6-22 * * ? *)"` | no |
| <a name="input_parent_acct_environment"></a> [parent\_acct\_environment](#input\_parent\_acct\_environment) | Name of the environment responsible for the acct resources used, affects things like DNS zone. Useful for named dev environments | `string` | `"main"` | no |
| <a name="input_pii_data_retention_non_current_days"></a> [pii\_data\_retention\_non\_current\_days](#input\_pii\_data\_retention\_non\_current\_days) | The number of non current days for data retention policy for PII | `number` | `14` | no |
| <a name="input_pii_data_retention_policy_days"></a> [pii\_data\_retention\_policy\_days](#input\_pii\_data\_retention\_policy\_days) | The number of days for data retention policy for PII | `number` | `534` | no |
| <a name="input_pii_data_retention_policy_days"></a> [pii\_data\_retention\_policy\_days](#input\_pii\_data\_retention\_policy\_days) | The number of days for data retention policy for PII | `number` | `90` | no |
| <a name="input_project"></a> [project](#input\_project) | The name of the tfscaffold project | `string` | n/a | yes |
| <a name="input_queue_batch_size"></a> [queue\_batch\_size](#input\_queue\_batch\_size) | maximum number of queue items to process | `number` | `10` | no |
| <a name="input_queue_batch_window_seconds"></a> [queue\_batch\_window\_seconds](#input\_queue\_batch\_window\_seconds) | maximum time in seconds between processing events | `number` | `1` | no |
Expand Down
18 changes: 18 additions & 0 deletions infrastructure/terraform/components/dl/module_s3bucket_pii_data.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,24 @@ module "s3bucket_pii_data" {

force_destroy = var.force_destroy

lifecycle_rules = [
{
enabled = true

expiration = {
days = var.pii_data_retention_policy_days
}

noncurrent_version_expiration = {
noncurrent_days = var.pii_data_retention_non_current_days
}

abort_incomplete_multipart_upload = {
days = "1"
}
}
]

default_tags = {
NHSE-Enable-S3-Backup-Acct = "True"
}
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/terraform/components/dl/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ variable "report_scheduler_schedule" {
variable "pii_data_retention_policy_days" {
type = number
description = "The number of days for data retention policy for PII"
default = 534
default = 90
}

variable "pii_data_retention_non_current_days" {
Expand Down
Loading