Skip to content

CCM-16553: Deployment into nft environment in NonProd#293

Merged
nhsd-angel-pastor merged 9 commits intomainfrom
feature/CCM-16553_dl_nft
Apr 30, 2026
Merged

CCM-16553: Deployment into nft environment in NonProd#293
nhsd-angel-pastor merged 9 commits intomainfrom
feature/CCM-16553_dl_nft

Conversation

@nhsd-angel-pastor
Copy link
Copy Markdown
Contributor

@nhsd-angel-pastor nhsd-angel-pastor commented Apr 15, 2026

Description

Deployment of main into nft and main environments for NonProd account. Added tool to publish events from the SupplierAPI and from Core (for the opt out letter). Evidences under comment

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-16553_dl_nft branch 6 times, most recently from 0abe021 to 07dced7 Compare April 20, 2026 16:16
Comment thread scripts/nft-event-generator/src/destinations/destination-client.ts
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-16553_dl_nft branch from 01acdc1 to d5ff9a7 Compare April 21, 2026 07:31
@nhsd-angel-pastor nhsd-angel-pastor marked this pull request as ready for review April 21, 2026 12:01
@nhsd-angel-pastor nhsd-angel-pastor requested review from a team as code owners April 21, 2026 12:01
Comment thread project.code-workspace
Copy link
Copy Markdown
Contributor

@gareth-allan gareth-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not reviewed the nft-event-generator application yet, but one comment on everything else.

Comment thread Makefile Outdated
simonlabarere
simonlabarere previously approved these changes Apr 23, 2026
Comment thread scripts/nft-event-generator/package.json Outdated
Comment thread scripts/package.json
Comment thread scripts/tsconfig.json Outdated
Comment thread scripts/tsconfig.json Outdated
Comment thread scripts/package.json Outdated
Comment thread scripts/package.json Outdated
Comment thread scripts/nft-event-generator/src/destinations/send-events-to-event-bus.ts Outdated
Comment thread scripts/nft-event-generator/README.md
Comment thread scripts/nft-event-generator/src/destinations/send-events-to-event-bus.ts Outdated
Comment thread scripts/nft-event-generator/src/generators/supplier-api-letter-events.ts Outdated
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-16553_dl_nft branch 3 times, most recently from bc42881 to 35ebe4f Compare April 27, 2026 14:08
Comment thread scripts/package.json Outdated
Comment thread scripts/nft-event-generator/src/destinations/send-events-to-event-bus.ts Outdated
Comment thread scripts/nft-event-generator/src/destinations/send-events-to-event-bus.ts Outdated
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-16553_dl_nft branch 3 times, most recently from 188a611 to 3102398 Compare April 29, 2026 09:25
@nhsd-angel-pastor nhsd-angel-pastor force-pushed the feature/CCM-16553_dl_nft branch from ecde7ec to 09c0cb5 Compare April 29, 2026 14:31
Comment thread .github/workflows/release_created.yaml
@nhsd-angel-pastor nhsd-angel-pastor merged commit c2c4a42 into main Apr 30, 2026
61 of 62 checks passed
@nhsd-angel-pastor nhsd-angel-pastor deleted the feature/CCM-16553_dl_nft branch April 30, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants