Skip to content

CCM-12274: Rework NHSApp callback design diagrams#258

Merged
tdroza-nhs merged 2 commits intomainfrom
feature/CCM-12274-app-callback-design
Mar 26, 2026
Merged

CCM-12274: Rework NHSApp callback design diagrams#258
tdroza-nhs merged 2 commits intomainfrom
feature/CCM-12274-app-callback-design

Conversation

@tdroza-nhs
Copy link
Copy Markdown
Contributor

Description

Diagram updates:

  • Renamed the NHSAppCallbackHandler component to NHSApp Status Handler
  • Changed design from consuming an webhook callback from Core, to receiving an event via the shared event bus
  • Removed the sequence diagram as the flow is now the same as all other components
image

Context

Enables receipt of the PrintLetterOptedOut status from NHSApp to suppress sending the PDF for print

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

simonlabarere
simonlabarere previously approved these changes Mar 25, 2026
@tdroza-nhs tdroza-nhs force-pushed the feature/CCM-12274-app-callback-design branch from 5a20a83 to f050494 Compare March 26, 2026 09:44
@tdroza-nhs tdroza-nhs merged commit a8d0cc4 into main Mar 26, 2026
25 checks passed
@tdroza-nhs tdroza-nhs deleted the feature/CCM-12274-app-callback-design branch March 26, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants