CCM-13675: Event code generation improvements#254
Merged
simonlabarere merged 18 commits intomainfrom Mar 31, 2026
Merged
Conversation
edf7a6f to
d45e448
Compare
simonlabarere
commented
Mar 24, 2026
simonlabarere
commented
Mar 24, 2026
simonlabarere
commented
Mar 24, 2026
504a803 to
8c42a94
Compare
simonlabarere
commented
Mar 24, 2026
simonlabarere
commented
Mar 24, 2026
nhsd-angel-pastor
previously approved these changes
Mar 25, 2026
Ian-Hodges
reviewed
Mar 25, 2026
Ian-Hodges
reviewed
Mar 26, 2026
Ian-Hodges
previously approved these changes
Mar 26, 2026
Contributor
Ian-Hodges
left a comment
There was a problem hiding this comment.
I'm liking it. Just the one comment about an error log potentially triggering duplicate alarms.
d09080e to
d69745d
Compare
nhsd-angel-pastor
previously approved these changes
Mar 27, 2026
gareth-allan
previously approved these changes
Mar 27, 2026
f7ceaa8 to
ee7a2b7
Compare
b216f80 to
a43fd07
Compare
nhsd-angel-pastor
approved these changes
Mar 31, 2026
ScottFullerton-NHSE
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generation of guard functions to assist in reducing boiler plate code and avoiding type casting. The behaviour of the whole app should remain unchanged with the exception of the normalisation of some logs.
Example of a generated guard function:
Which can be used like this:
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.