CCM-14974: Additional failure events in CSV reports#245
Merged
simonlabarere merged 28 commits intomainfrom Mar 31, 2026
Merged
Conversation
Bumps [h3](https://github.com/h3js/h3) from 1.15.5 to 1.15.8. - [Release notes](https://github.com/h3js/h3/releases) - [Changelog](https://github.com/h3js/h3/blob/main/CHANGELOG.md) - [Commits](h3js/h3@v1.15.5...v1.15.8) --- updated-dependencies: - dependency-name: h3 dependency-version: 1.15.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
simonlabarere
left a comment
simonlabarere
left a comment
There was a problem hiding this comment.
A few comments, sorry!
tdroza-nhs
requested changes
Mar 19, 2026
…-reports-failure-events # Conflicts: # package-lock.json # src/eventcatalog/package-lock.json # src/eventcatalog/package.json
…tcatalog/h3-1.15.8' into feature/CCM-14974-csv-reports-failure-events
simonlabarere
previously approved these changes
Mar 20, 2026
simonlabarere
approved these changes
Mar 27, 2026
tdroza-nhs
approved these changes
Mar 27, 2026
Contributor
tdroza-nhs
left a comment
tdroza-nhs
left a comment
There was a problem hiding this comment.
Requested changes have all been actioned.
aidenvaines-cgi
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added 4 existing events to the failure report:
We also included the failure reasons and codes for these as part of the ticket. I spoke to Tom D and we agreed the best approach was to put the failure codes and reasons into a Glue Table and have the daily report query it against failure codes from the glue event record table to match a failure reason in the report.
I've also included a fix for the current trivy vulnerabilities - including pulling in one of dependabot's PRs.
Context
These events could lead to a failure, and we want to send comprehensive reports to trusts, so they understand why a request might have failed.
Type of changes
Validation
CSV From the component tests:
https://820178564574-pu7sllom.eu-west-2.console.aws.amazon.com/s3/object/nhs-820178564574-eu-west-2-pr245-dl-reporting?region=eu-west-2&prefix=event-reports/report-generator-test-90436e79-3cf0-4d8e-a787-0adc86af73cf/completed_communications/completed_communications_2026-03-27.csv
completed_communications_2026-03-27.csv
The core status reason should only be sent in the event that a failure reason isn't provided back from core (one should always be).
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.