Skip to content

CCM-14480: Centralize terraform module source configuration#221

Closed
lapenna-bjss wants to merge 3 commits intomainfrom
feature/CCM-14480_centralize_terraform_module_source_config
Closed

CCM-14480: Centralize terraform module source configuration#221
lapenna-bjss wants to merge 3 commits intomainfrom
feature/CCM-14480_centralize_terraform_module_source_config

Conversation

@lapenna-bjss
Copy link
Copy Markdown
Collaborator

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

Copy link
Copy Markdown
Contributor

@aidenvaines-cgi aidenvaines-cgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont do this please Luca :D

@lapenna-bjss
Copy link
Copy Markdown
Collaborator Author

We can’t centralise the module sources because they cannot be dynamic. Terraform resolves module sources during init before it resolves vars and locals, so that approach will not work. We also agreed that wrapper modules are not a viable solution, so we’ll keep the source values static. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants