Skip to content

CCM-13146 Component tests for handling ttl#145

Merged
Ian-Hodges merged 17 commits intomainfrom
feature/CCM-13146_handle-ttl-component-tests
Dec 10, 2025
Merged

CCM-13146 Component tests for handling ttl#145
Ian-Hodges merged 17 commits intomainfrom
feature/CCM-13146_handle-ttl-component-tests

Conversation

@Ian-Hodges
Copy link
Copy Markdown
Contributor

@Ian-Hodges Ian-Hodges commented Dec 5, 2025

Description

Adds new component tests for the handling of ttl items.

Context

Added to give extra assurance that our code is functioning as expected.

Test evidence

Successful deployment with passing tests:

image

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@Ian-Hodges Ian-Hodges marked this pull request as ready for review December 8, 2025 11:48
@Ian-Hodges Ian-Hodges requested review from a team as code owners December 8, 2025 11:48
@Ian-Hodges Ian-Hodges changed the title Feature/ccm 13146 handle ttl component tests CCM-13146 Component tests for handling ttl Dec 8, 2025
Copy link
Copy Markdown
Contributor

@nhsd-angel-pastor nhsd-angel-pastor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread tests/playwright/helpers/cloudwatch-helpers.ts
Comment thread tests/playwright/helpers/sqs-helpers.ts Outdated
Comment thread tests/playwright/helpers/sqs-helpers.ts
sidnhs
sidnhs previously approved these changes Dec 10, 2025
@Ian-Hodges Ian-Hodges dismissed stale reviews from nhsd-angel-pastor and sidnhs via 8f4fd35 December 10, 2025 14:24
@Ian-Hodges Ian-Hodges merged commit 6487e77 into main Dec 10, 2025
36 checks passed
@Ian-Hodges Ian-Hodges deleted the feature/CCM-13146_handle-ttl-component-tests branch December 10, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants