tools versions & cicd publish-stage & codespace devcontainer #105
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -164,8 +164,7 @@ jobs: | |
| APP_CLIENT_ID: ${{ secrets.APP_CLIENT_ID }} | ||
| publish-stage: # Recommended maximum execution time is 10 minutes | ||
|
Contributor
There was a problem hiding this comment. This might be better moved to pr_closed? There it will only run on main and after the acceptance tests have run.
Contributor
Author
There was a problem hiding this comment. reason I've kept it here, is so i can push direct to main on a fork, and have this go through. otherwise on a fork when testing CICD to GHP, you would have to do your own pr to yourself.
Contributor
There was a problem hiding this comment. I don't think we should be making compromises to support forks.
Contributor
Author
There was a problem hiding this comment. any suggestion on how to support forks?
Contributor
There was a problem hiding this comment. For this isolated example you can amend the workflow on the forked repo.
Contributor
Author
There was a problem hiding this comment. Think this is a wider conversation to fully move the publish stage out of here. Probably need to look at how our repository template (https://github.com/NHSDigital/nhs-notify-repository-template/tree/main/.github/workflows) is different from the NHSE template (https://github.com/nhs-england-tools/repository-template/tree/main/.github/workflows), in that we don't have the separate publish workflow, and that to get around that for this to be able to publish its just in https://github.com/NHSDigital/nhs-notify-digital-letters/blob/main/.github/workflows/cicd-1-pull-request.yaml instead.
Contributor
Author
There was a problem hiding this comment. Would like to suggest that removing this at present is a breaking changes for a fork, so to leave it in. Then will look separately at bringing in the workflow "2 publish" and look at fully moving the publish stage out of this workflow?
Contributor
There was a problem hiding this comment. I'd prefer to leave this as-is while we decide on the best place for it. |
||
| name: "Publish stage" | ||
| needs: [metadata, build-stage] | ||
| uses: ./.github/workflows/stage-5-publish.yaml | ||
| if: (github.event_name == 'push' && github.ref == 'refs/heads/main') | ||
| with: | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| act 0.2.64 | ||
| gitleaks 8.24.0 | ||
| jq 1.6 | ||
| nodejs 22.11.0 | ||
| pre-commit 3.6.0 | ||
| python 3.13.2 | ||
| terraform 1.10.1 | ||
|
|
||
|
Contributor
There was a problem hiding this comment. I'm not a fan of all these .tool-versions files. Do these packages need node 24?
Contributor
Author
There was a problem hiding this comment. Unsure if they will play ball with 22. I do think this is the point of tools versions though so can do monorepo support for tools versioning?
Contributor
There was a problem hiding this comment. I'm not sure it works well with npm workspaces and make where most commands are ran from the root directory. If you are keeping them, I presume you don't need all those tools i.e. terraform stuff?
Contributor
Author
There was a problem hiding this comment. most of the make uses make -C so it runs child ones from their directory. Have gone through and removed all redundant lines. Was a good spot though as the template doesn't proactively install child tools versions - something that we've missed as there is an existing tool-versions nested in there. Have done a separate pr to backport changes - see change to init.mk |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| act 0.2.64 | ||
| gitleaks 8.24.0 | ||
| jq 1.6 | ||
| nodejs 24.10.0 | ||
| pre-commit 3.6.0 | ||
| python 3.13.2 | ||
| terraform 1.10.1 | ||
| terraform-docs 0.19.0 | ||
| trivy 0.61.0 | ||
| vale 3.6.0 |
|
tdroza-nhs marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| act 0.2.64 | ||
| gitleaks 8.24.0 | ||
| jq 1.6 | ||
| nodejs 24.10.0 | ||
| pre-commit 3.6.0 | ||
| python 3.13.2 | ||
| terraform 1.10.1 | ||
| terraform-docs 0.19.0 | ||
| trivy 0.61.0 | ||
| vale 3.6.0 |
|
RossBugginsNHS marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Schema Generation | ||
|
|
||
| Owner: RossBugginsNHS | ||
| Author: Claude Sonnet 4.5 | ||
| Date: November 2025 | ||
|
|
||
| ## Summary | ||
|
|
||
| The code within here is for generating json schemas for the source yaml schemas. | ||
|
|
||
| [src/cloudevents/domains/digital-letters/2025-10-draft](src/cloudevents/domains/digital-letters/2025-10-draft) is where the source for the schemas is located. | ||
|
|
||
| At build time they will be generated and outputted to the docs folder, ready for deployment to github pages. |
|
tdroza-nhs marked this conversation as resolved.
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,21 +7,3 @@ terraform 1.10.1 | |
| terraform-docs 0.19.0 | ||
| trivy 0.61.0 | ||
| vale 3.6.0 | ||
Uh oh!
There was an error while loading. Please reload this page.