Skip to content

Chore: [AEA-0000] - use gitleaks for secret scanning #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Apr 17, 2026
Merged

Chore: [AEA-0000] - use gitleaks for secret scanning #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .gitallowed
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ repos:
pass_filenames: false
always_run: true

- id: git-secrets
name: Git Secrets
description: git-secrets scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
- id: gitleaks
name: Git Leaks
description: gitleaks scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hook description claims it scans commit messages and --no-ff merges, but this pre-commit hook runs at the pre-commit stage and the configured command appears to only scan staged content. Please update the description to reflect the actual behavior, or add separate hooks/stages (e.g., commit-msg/post-merge) if those checks are intended.

Suggested change
description: gitleaks scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
description: gitleaks scans staged changes during pre-commit to help prevent adding secrets to the repository.

Copilot uses AI. Check for mistakes.
entry: bash
args:
- -c
- 'git-secrets --pre_commit_hook'
- "gitleaks git --pre-commit --redact --staged --verbose"
language: system
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook uses language: system with entry: bash -c ... and doesn’t appear to consume the filenames pre-commit will pass by default. Consider setting pass_filenames: false (and, if you want a pinned/managed version, using the official gitleaks pre-commit repo instead of a system dependency) to avoid unnecessary args and potential command-line length issues when many files are staged.

Suggested change
language: system
language: system
pass_filenames: false

Copilot uses AI. Check for mistakes.
fail_fast: true
default_stages: [pre-commit]