Skip to content

Chore: [AEA-0000] - add ignore-scripts to npm ci #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Apr 15, 2026
Merged

Chore: [AEA-0000] - add ignore-scripts to npm ci #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ install-hooks:
poetry run pre-commit install --install-hooks --overwrite

install-node:
npm ci
npm ci --ignore-scripts
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci --ignore-scripts will skip all dependency lifecycle scripts. In the current package-lock.json there are dependencies marked hasInstallScript (e.g., unrs-resolver used by jest-resolve), so this change can alter runtime behavior and potentially break npm run test/npm run lint if any required postinstall step is skipped. Consider restricting --ignore-scripts to CI-only (or adding a separate make target) and/or explicitly verifying in CI that build/lint/test still pass after a clean install with scripts disabled.

Suggested change
npm ci --ignore-scripts
npm ci

Copilot uses AI. Check for mistakes.

build:
npm run build
Expand Down