Skip to content

Appt 2108: Refactor to a common ICacheStore interface to enable distributed cache#1563

Open
pata9 wants to merge 16 commits intomainfrom
APPT-2108/refactor_cachestore
Open

Appt 2108: Refactor to a common ICacheStore interface to enable distributed cache#1563
pata9 wants to merge 16 commits intomainfrom
APPT-2108/refactor_cachestore

Conversation

@pata9
Copy link
Copy Markdown
Contributor

@pata9 pata9 commented Mar 26, 2026

Description

Removed all dependencies on in memory interface from around the solution and centralised it into a new interface.

Fixes # (issue)

Checklist:

  • My work is behind a feature toggle (if appropriate)
  • If my work is behind a feature toggle, I've added a full suite of tests for both the ON and OFF state
  • The ticket number is in the Pull Request title, with format "APPT-XXX: My Title Here"
  • I have ran npm tsc / lint (in the future these will be ran automatically)
  • My code generates no new .NET warnings (in the future these will be treated as errors)
  • If I've added a new Function, it is disabled in all but one of the terraform groups (e.g. http_functions)
  • If I've added a new Function, it has both unit and integration tests. Any request body validators have unit tests also
  • If I've made UI changes, I've added appropriate Playwright and Jest tests
  • If I've added/updated an end-point, I've added the appropriate annotations and tested the Swagger documentation reflects the change

@pata9 pata9 requested review from Dave-O-NHS, jsed-nhs and ste-banks and removed request for jsed-nhs and ste-banks March 26, 2026 15:37
@pata9 pata9 changed the title Appt 2108: Refactor to a common ICashStore interface to enable distributed cache Appt 2108: Refactor to a common ICasheStore interface to enable distributed cache Apr 1, 2026
@pata9 pata9 changed the title Appt 2108: Refactor to a common ICasheStore interface to enable distributed cache Appt 2108: Refactor to a common ICacheStore interface to enable distributed cache Apr 1, 2026
@pata9
Copy link
Copy Markdown
Contributor Author

pata9 commented Apr 1, 2026

Add logging to the try pattern

Comment thread src/api/Nhs.Appointments.Api/Auth/JwksRetriever.cs Outdated
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines:
Successfully started running 1 pipeline(s).

@pata9 pata9 requested a review from a team as a code owner April 17, 2026 13:35
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant