[NDR-387] Rationalise GitHub Role files#637
Merged
tim-knight-nhs merged 30 commits intomainfrom Mar 26, 2026
Merged
Conversation
chrisbloe
reviewed
Mar 25, 2026
|
Report for environment: ndr-devTerraform Initialization ⚙️
|
megan-bower4
approved these changes
Mar 26, 2026
chrisbloe
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Overview
Jira ticket: NDR-387
Description
Currently, we have four main Github Role Terraform file in the base_iam directory. One for each environment (iam_github_*.tf)
There are currently many repeated permissions within each file and lots of overlap between files.
This ticket aims to:
Context
The current format is hard to interpret and maintain.
It's hard to get a sense of where a given permission may be deployed. Or if it's been applied multiple times.
By splitting into related files, this ticket aims to make it easier to review.
Checklist
Tasks for all changes:
I have updated relevant documentation.ndr-dev.