mesh-2433 changes#184
Merged
james-bradley-nhs merged 13 commits intodevelopfrom Jul 8, 2025
Merged
Conversation
johnwilliams57-nhs
requested changes
Jun 25, 2025
Contributor
johnwilliams57-nhs
left a comment
johnwilliams57-nhs
left a comment
There was a problem hiding this comment.
looks good. would you mind using or removing that constant and adding the types?
cheers.
Contributor
☂️ Python Cov
Overall Coverage
New FilesNo new covered files... Modified Files
|
johnwilliams57-nhs
requested changes
Jul 8, 2025
Contributor
johnwilliams57-nhs
left a comment
johnwilliams57-nhs
left a comment
There was a problem hiding this comment.
great stuff. just one really minor comment on a nullable type
| class UploadChunkV1(BaseModel): | ||
| messageID: str = Field(default=None, description="message identifier, as supplied in the request url") | ||
| blockID: int = Field(default=None, description="chunk number, as supplied in the request url") | ||
| messageID: str = Field(default=None, description="message identifier, as supplied in the request url") # type: ignore |
Contributor
There was a problem hiding this comment.
shouldn't this be
messageID: str | None = ...
and same with blockID?
johnwilliams57-nhs
previously approved these changes
Jul 8, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.