Change the testing API /api/testing/vaccinations-search-in-nhs to a polling approach#6763
Open
Change the testing API /api/testing/vaccinations-search-in-nhs to a polling approach#6763
Conversation
…olling Unfortunately the synchronous approach was too simplistic. In E2E test runs on the QA environment, we're seeing 504 timeouts as it's likely that the synchronous testing API endpoint is taking too long for the search jobs to drain. Instead, move to an approach whereby: * the test starts with a POST and receives a 202 * it then polls with a GET * if the queue hasn't drained yet, status 202 is returned * otherwise (when the search queue is finally empty) status 200 is returned
benilovj
force-pushed
the
fix-vaccinations-search-in-nhs-async
branch
from
47b3aa3 to
a020b72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the synchronous approach was too simplistic. In E2E test runs on the QA environment, we're seeing 504 timeouts as it's likely that the synchronous testing API endpoint is taking too long for the search jobs to drain.
Instead, move to an approach whereby:
See NHSDigital/manage-vaccinations-in-schools-testing#1164