Fix invalid vaccination dates in already vaccinated flow#6762
Open
jhenderson wants to merge 1 commit intonextfrom
Open
Fix invalid vaccination dates in already vaccinated flow#6762jhenderson wants to merge 1 commit intonextfrom
jhenderson wants to merge 1 commit intonextfrom
Conversation
The "record as already vaccinated" flow from a child programme page creates a session-less `DraftVaccinationRecord`. In that path, draft date validation was not being enforced consistently, so invalid vaccination dates could reach the check-and-confirm step and then fail later when `VaccinationRecord` validation ran on save. Update `DraftVaccinationRecord` so `performed_at_date` range validation runs during draft updates for session-less manual-report flows as well as session-backed flows. Jira-Issue: MAV-7121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "record as already vaccinated" flow from a child programme page creates a session-less
DraftVaccinationRecord. In that path, draft date validation was not being enforced consistently, so invalid vaccination dates could reach the check-and-confirm step and then fail later whenVaccinationRecordvalidation ran on save.Update
DraftVaccinationRecordsoperformed_at_daterange validation runs during draft updates for session-less manual-report flows as well as session-backed flows.Jira Issue - MAV-7121
Screenshots