Use Sidekiq's API directly (part 2 of 3)#6741
Open
thomasleese wants to merge 2 commits intouse-sidekiq-directly-1from
Open
Use Sidekiq's API directly (part 2 of 3)#6741thomasleese wants to merge 2 commits intouse-sidekiq-directly-1from
thomasleese wants to merge 2 commits intouse-sidekiq-directly-1from
Conversation
thomasleese
changed the title
thomasleese
force-pushed
the
use-sidekiq-directly-2
branch
2 times, most recently
from
763575a to
884661b
Compare
This removes the remaining ActiveJob jobs and replaces them with the Sidekiq equivalents. This is safe to deploy because there are no more ActiveJob jobs in the queues. For now we keep around the old classes (prefixed with `Sidekiq`) in case any are in the queue when this is deployed. Jira-Issue: MAV-7288
thomasleese
force-pushed
the
use-sidekiq-directly-2
branch
from
884661b to
6ead5a6
Compare
This removes the ActiveJob Railtie and stops including the test helper to make it explicit that we're not using ActiveJob anymore. Jira-Issue: MAV-7288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the remaining ActiveJob jobs and replaces them with the Sidekiq equivalents. This is safe to deploy because there are no more ActiveJob jobs in the queues.
For now we keep around the old classes (prefixed with
Sidekiq) in case any are in the queue when this is deployed.Jira Issue - MAV-7288