Refactor PDSCascadingSearchJob to use strings#6738
Open
thomasleese wants to merge 3 commits intonextfrom
Open
Conversation
thomasleese
force-pushed
the
pds-cascading-job-strings
branch
from
89e41f8 to
fd215eb
Compare
thomasleese
force-pushed
the
pds-cascading-job-strings
branch
4 times, most recently
from
0f0fd91 to
fc0155e
Compare
Since it doesn't need to be dynamic. Jira-Issue: MAV-7288
This is in preparation for converting this job to Sidekiq where all arguments need to be JSON serialisable, of which symbols are not. We also store these values in a JSON blob on the `PatientChangeset` model so I think it makes sense to use strings here since they will be serialised in to strings anyway. I've removed a `describe` block from the test to simplify the file, which has resulted in a whitespace change on each line as the code is de-indented. Jira-Issue: MAV-7288
In the previous commit this job was converted to use string arguments. This adds a fallback to ensure that if any existing jobs with symbols are executed correctly. Jira-Issue: MAV-7288
thomasleese
force-pushed
the
pds-cascading-job-strings
branch
from
fc0155e to
77d2ba7
Compare
murugapl
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in preparation for converting this job to Sidekiq where all arguments need to be JSON serialisable, of which symbols are not.
We also store these values in a JSON blob on the
PatientChangesetmodel so I think it makes sense to use strings here since they will be serialised in to strings anyway.I've removed a
describeblock from the test to simplify the file, which has resulted in a whitespace change on each line as the code is de-indented.Jira Issue - MAV-7288