Skip to content

Remove unused method in PatientStatusUpdater#6717

Merged
floehopper merged 1 commit intonextfrom
remove-unused-method-in-patient-status-updater
Apr 28, 2026
Merged

Remove unused method in PatientStatusUpdater#6717
floehopper merged 1 commit intonextfrom
remove-unused-method-in-patient-status-updater

Conversation

@floehopper
Copy link
Copy Markdown
Contributor

This method implementation and an invocation from PatientStatusUpdater#update_programme_statuses! was originally added in this commit in #6468.

Both the implementation and invocation were removed in this commit in #6611.

Then the implementation was then re-added without the corresponding invocation in this commit within #6677 which was the "Version 8.1.0" pull request.

Since the method is never invoked, it's safe to remove it.

This method implementation and an invocation from
`PatientStatusUpdater#update_programme_statuses!` was originally added in
this commit [1] in #6468.

Both the implementation and invocation were removed in this commit [2] in #6611.

Then the implementation was then re-added without the corresponding invocation
in this commit [3] within #6677 which was the "Version 8.1.0" pull request.

Since the method is never invoked, it's safe to remove it.

[1]: 25e876a
[2]: 29460d4
[3]: c66b757
@floehopper floehopper force-pushed the remove-unused-method-in-patient-status-updater branch from 559b071 to 58083d6 Compare April 28, 2026 15:23
@floehopper floehopper marked this pull request as ready for review April 28, 2026 16:30
@floehopper floehopper requested a review from a team as a code owner April 28, 2026 16:30
@floehopper floehopper merged commit 39736a3 into next Apr 28, 2026
15 checks passed
@floehopper floehopper deleted the remove-unused-method-in-patient-status-updater branch April 28, 2026 16:33
@thomasleese thomasleese added the refactor Improving maintainability label Apr 28, 2026
@thomasleese thomasleese added this to the v8.3.0 milestone Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Improving maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants