Clarify MMR historical dose sequence validation message#6699
Open
jhenderson wants to merge 1 commit intonextfrom
Open
Clarify MMR historical dose sequence validation message#6699jhenderson wants to merge 1 commit intonextfrom
jhenderson wants to merge 1 commit intonextfrom
Conversation
This follows on from commit 9035a26 and QA feedback. Update the dose sequence validation copy to use a single clearer error message. Jira-Issue: MAV-2312
jhenderson
force-pushed
the
fix-mmr-upload-dose-sequence-part-2
branch
from
ba74db8 to
fab5774
Compare
misaka
reviewed
Apr 27, 2026
| ) | ||
|
|
||
| dose_sequence_error_message = | ||
| "Enter a numeric which must be either #{dose_sequence_examples}." |
Collaborator
There was a problem hiding this comment.
"Enter a numeric ..."? Just double-checking this is correct, it doesn't sound better to me but happy to approve if this was deemed so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the validation error for invalid MMR historical dose sequence values more consistent when uploading vaccination records.
Before this change, invalid values such as
3and2Bcould show different error messages. This change updates the wording so they now both show the same message explaining that the dose sequence cannot be greater than 2.This is a follow up from #6560 after QA feedback.
Jira Issue - MAV-7123