Add execution_id to the Sidekiq middleware#6199
Merged
alistair-white-horne-tng merged 1 commit intonextfrom Mar 5, 2026
Merged
Add execution_id to the Sidekiq middleware#6199alistair-white-horne-tng merged 1 commit intonextfrom
execution_id to the Sidekiq middleware#6199alistair-white-horne-tng merged 1 commit intonextfrom
Conversation
alistair-white-horne-tng
added
operations
thomasleese
approved these changes
Mar 5, 2026
thomasleese
approved these changes
Mar 5, 2026
This means that all jobs will have improved logging: - `jid` is the same across retry runs of the same job (this already existed in the previous implementation). This is now also sent to Sentry. - `execution_id` is the replacement for `tx_id`. This changes between retry runs, but still doesn't tag the `Start #perform` and `Completed #perform` log messages. This is seemingly much more difficult. Jira-Issue: MAV-4085
alistair-white-horne-tng
force-pushed
the
alistair/job-tagging
branch
from
50f7fbf to
14a9196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that all jobs will have improved logging:
jidis the same across retry runs of the same job (this already existed in the previous implementation). This is now also sent to Sentry.execution_idis the replacement fortx_id. This changes between retry runs, but still doesn't tag theStart #performandCompleted #performlog messages. This is seemingly much more difficult.MAV-4085