Skip to content

Refactor SchoolsController#6183

Merged
thomasleese merged 1 commit intonextfrom
refactor-schools-controller
Mar 4, 2026
Merged

Refactor SchoolsController#6183
thomasleese merged 1 commit intonextfrom
refactor-schools-controller

Conversation

@thomasleese
Copy link
Copy Markdown
Contributor

This refactors the controller and splits it up in to separate controllers for each of the various parts of the schools section of the service. This improves maintainability as the class was getting quite big.

Jira Issue - MAV-3886

@thomasleese thomasleese added this to the v7.2.0 milestone Mar 4, 2026
@thomasleese thomasleese requested a review from a team as a code owner March 4, 2026 11:22
@thomasleese thomasleese added the refactor Improving maintainability label Mar 4, 2026
@thomasleese thomasleese enabled auto-merge March 4, 2026 11:23
@thomasleese thomasleese force-pushed the refactor-schools-controller branch from 4223f83 to 02a4a50 Compare March 4, 2026 15:52
Copy link
Copy Markdown
Contributor

@stevehook stevehook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread config/routes.rb Outdated
@thomasleese thomasleese force-pushed the refactor-schools-controller branch 2 times, most recently from 8462fe9 to c752faa Compare March 4, 2026 16:46
This refactors the controller and splits it up in to separate
controllers for each of the various parts of the schools section of the
service. This improves maintability as the class was getting quite big.

Jira-Issue: MAV-3886
@thomasleese thomasleese force-pushed the refactor-schools-controller branch from c752faa to a46c07f Compare March 4, 2026 17:02
@thomasleese thomasleese merged commit 0f25538 into next Mar 4, 2026
13 of 15 checks passed
@thomasleese thomasleese deleted the refactor-schools-controller branch March 4, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Improving maintainability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants