Skip to content

Targeting was preveing output updates#3368

Merged
TheOneFromNorway merged 1 commit intomainfrom
remove_problematic_targeting_in_workflow
Apr 9, 2025
Merged

Targeting was preveing output updates#3368
TheOneFromNorway merged 1 commit intomainfrom
remove_problematic_targeting_in_workflow

Conversation

@TheOneFromNorway
Copy link
Copy Markdown
Contributor

@TheOneFromNorway TheOneFromNorway commented Apr 9, 2025 •
edited
Loading

  • Validation script should in any case catch any invalid resource modifications
  • With this change we lose the ability to only deploy application via github workflow in the case of infrastructure changes. This is considered an unlikely edge case and therefore worth the risk.

@TheOneFromNorway
Targeting was preveing output updates
ec86327 
- Validation script should in any case catch any invalid resource
  modifications
@TheOneFromNorway TheOneFromNorway force-pushed the remove_problematic_targeting_in_workflow branch from 762a401 to ec86327 Compare April 9, 2025 12:35
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@TheOneFromNorway TheOneFromNorway merged commit 2783442 into main Apr 9, 2025
33 checks passed
@TheOneFromNorway TheOneFromNorway deleted the remove_problematic_targeting_in_workflow branch April 9, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasleese thomasleese thomasleese approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TheOneFromNorway @thomasleese @tvararu