Merge pull request #5566 from nhsuk/hide-year-groups

Hide year groups in clinic sessions

Author: thomasleese

app/models/draft_session.rb

@@ -189,6 +189,8 @@ def patient_is_catch_up?(patient, programmes:)
 
   def dates = session_dates.map(&:value).compact.sort.uniq
 
+  def can_change_year_groups? = school? && !editing?
+
   def set_notification_dates
     if earliest_date
       if generic_clinic?

app/views/draft_sessions/confirm.html.erb

@@ -27,12 +27,14 @@
           row.with_action(text: "Change", href: draft_session_path("programmes"), visually_hidden_text: "programmes")
         end
 
-        summary_list.with_row do |row|
-          row.with_key { "Year groups" }
-          row.with_value { format_year_groups(@draft_session.year_groups) }
+        if @draft_session.school?
+          summary_list.with_row do |row|
+            row.with_key { "Year groups" }
+            row.with_value { format_year_groups(@draft_session.year_groups) }
 
-          unless @draft_session.editing?
-            row.with_action(text: "Change", href: draft_session_path("year-groups"), visually_hidden_text: "year groups")
+            if @draft_session.can_change_year_groups?
+              row.with_action(text: "Change", href: draft_session_path("year-groups"), visually_hidden_text: "year groups")
+            end
           end
         end
 

spec/features/sessions_clinic_spec.rb

@@ -177,6 +177,7 @@ def and_i_choose_the_dates
 
   def then_i_see_the_confirmation_page
     expect(page).to have_content("Check and confirm")
+    expect(page).not_to have_content("Year groups")
     expect(page).to have_content("InvitationsSend on Sunday, 18 February 2024")
   end
 

spec/features/sessions_school_spec.rb

@@ -295,6 +295,8 @@ def when_i_choose_the_dates
 
   def then_i_see_the_confirmation_page
     expect(page).to have_content("Check and confirm")
+    expect(page).to have_content("Year groupsYears 8 to 11")
+    expect(page).to have_link("Change year groups")
     expect(page).to have_content("Register attendanceYes")
   end