Merge pull request #5569 from nhsuk/make-disease-types-not-null

Make `disease_types` not null

Author: thomasleese

app/models/vaccination_record.rb

@@ -9,7 +9,7 @@
 #  delivery_method                         :integer
 #  delivery_site                           :integer
 #  discarded_at                            :datetime
-#  disease_types                           :enum             is an Array
+#  disease_types                           :enum             not null, is an Array
 #  dose_sequence                           :integer
 #  full_dose                               :boolean
 #  local_patient_id_uri                    :string

db/migrate/20251215124426_make_vaccination_record_disease_types_not_null.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class MakeVaccinationRecordDiseaseTypesNotNull < ActiveRecord::Migration[8.1]
+  def change
+    change_column_null :vaccination_records, :disease_types, false
+  end
+end

db/schema.rb

@@ -935,7 +935,7 @@
     t.integer "delivery_method"
     t.integer "delivery_site"
     t.datetime "discarded_at"
-    t.enum "disease_types", array: true, enum_type: "disease_type"
+    t.enum "disease_types", null: false, array: true, enum_type: "disease_type"
     t.integer "dose_sequence"
     t.boolean "full_dose"
     t.string "local_patient_id"

lib/tasks/data_migration.rake

@@ -5,17 +5,4 @@ namespace :data_migration do
   task delete_clinic_session_notifications: :environment do
     SessionNotification.where(type: [1, 2]).delete_all
   end
-
-  desc "Set disease types on vaccination records."
-  task set_disease_types: :environment do
-    VaccinationRecord
-      .includes(:vaccine)
-      .where(disease_types: nil)
-      .find_each do |vaccination_record|
-        disease_types =
-          vaccination_record.vaccine&.disease_types ||
-            vaccination_record.programme.disease_types
-        vaccination_record.update_columns(disease_types:)
-      end
-  end
 end

spec/factories/vaccination_records.rb

@@ -9,7 +9,7 @@
 #  delivery_method                         :integer
 #  delivery_site                           :integer
 #  discarded_at                            :datetime
-#  disease_types                           :enum             is an Array
+#  disease_types                           :enum             not null, is an Array
 #  dose_sequence                           :integer
 #  full_dose                               :boolean
 #  local_patient_id_uri                    :string

spec/models/vaccination_record_spec.rb

@@ -9,7 +9,7 @@
 #  delivery_method                         :integer
 #  delivery_site                           :integer
 #  discarded_at                            :datetime
-#  disease_types                           :enum             is an Array
+#  disease_types                           :enum             not null, is an Array
 #  dose_sequence                           :integer
 #  full_dose                               :boolean
 #  local_patient_id_uri                    :string