Do not process patients that have skipped school move

These records should be skipped entirely from the import so no changes to the
base patient are made from data that is very likely to be outdated (why we're skipping
the school moves in the first place)

Author: murugapl

app/jobs/commit_import_job.rb

@@ -39,12 +39,19 @@ def perform(import_global_id)
       changesets
         .from_file
         .includes(:school)
-        .find_in_batches(batch_size: 100) do |changesets|
-          increment_column_counts!(import, counts, changesets)
+        .find_in_batches(batch_size: 100) do |batch|
+          to_skip = batch.select(&:school_move_to_unknown_from_another_team?)
+          to_process = batch - to_skip
 
-          import_patients_and_parents(changesets, import)
-          import_school_moves(changesets, import)
-          import_pds_search_results(changesets, import)
+          if to_process.any?
+            increment_column_counts!(import, counts, to_process)
+
+            import_patients_and_parents(to_process, import)
+            import_school_moves(to_process, import)
+            import_pds_search_results(to_process, import)
+          end
+
+          to_skip.each(&:processed!)
         end
 
       PatientTeamUpdater.call(patient_scope: import.patients)

app/jobs/commit_patient_changesets_job.rb

@@ -31,6 +31,8 @@ def perform(patient_changeset_ids)
       changesets.update_all(patient_id: nil)
 
       to_process = changesets.select { review_consistent?(it) }
+      to_skip = changesets.select(&:skipped_school_move?)
+      to_process -= to_skip
 
       if to_process.any?
         increment_column_counts!(import, counts, to_process)
@@ -40,6 +42,8 @@ def perform(patient_changeset_ids)
         to_process.each(&:processed!)
       end
 
+      to_skip.each(&:processed!)
+
       PatientTeamUpdater.call(patient_scope: import.patients)
     end
 

spec/features/import_child_records_review_spec.rb

@@ -20,6 +20,8 @@
     and_i_should_see_the_skipped_school_moves_summary
     and_the_patient_should_remain_at_their_current_school
     and_the_patient_should_not_be_linked_to_my_team
+    and_the_patient_should_not_be_linked_to_the_import
+    and_the_import_changes_should_not_be_processed
   end
 
   def given_i_am_signed_in
@@ -117,4 +119,12 @@ def and_the_patient_should_not_be_linked_to_my_team
     expect(@patient.teams).not_to include(@team)
     expect(@patient.teams).to contain_exactly(@other_team)
   end
+
+  def and_the_patient_should_not_be_linked_to_the_import
+    expect(@patient.cohort_imports).to be_empty
+  end
+
+  def and_the_import_changes_should_not_be_processed
+    expect(@patient.parents).to be_empty
+  end
 end