Display skipped school moves on import screens

This displays the skipped school moves on the import review screen and the
completed import screen.
This will not work if the import review screen flag is off, but given we
want to remove the flag soon, and always have it on, that shouldn't be a problem.

Author: murugapl

app/controllers/cohort_imports_controller.rb

@@ -71,6 +71,12 @@ def show
         @cohort_import.changesets.includes(:patient).nhs_number_discrepancies
 
       @cancelled = @cohort_import.changesets.from_file.cancelled
+      @skipped_school_moves =
+        @cohort_import
+          .changesets
+          .includes(:patient, patient: :school)
+          .from_file
+          .skipped_school_move
     end
 
     render template: "imports/show",
@@ -186,5 +192,11 @@ def set_review_records
         .includes(:school, patient: :school)
         .ready_for_review
         .with_school_moves - @inter_team
+    @skipped_school_moves =
+      @cohort_import
+        .changesets
+        .includes(:patient, patient: :school)
+        .ready_for_review
+        .skipped_school_move
   end
 end

app/models/patient_changeset.rb

@@ -76,7 +76,13 @@ class PatientChangeset < ApplicationRecord
        validate: true
 
   enum :record_type,
-       { auto_match: 0, new_patient: 1, import_issue: 2, not_in_file: 3 },
+       {
+         auto_match: 0,
+         new_patient: 1,
+         import_issue: 2,
+         not_in_file: 3,
+         skipped_school_move: 4
+       },
        validate: true
 
   scope :nhs_number_discrepancies,
@@ -464,6 +470,8 @@ def stage_and_handle_pending_changes(existing_patient)
   def changeset_type
     if patient.id.nil?
       :new_patient
+    elsif school_move_to_unknown_from_another_team?
+      :skipped_school_move
     elsif patient.pending_changes.any?
       :import_issue
     else

app/views/imports/show.html.erb

@@ -65,6 +65,7 @@
         auto_matched_records: @auto_matched_records,
         import_issues: @import_issues,
         school_moves: @school_moves,
+        skipped_school_moves: @skipped_school_moves || [],
       ) %>
 <% end %>
 
@@ -86,6 +87,27 @@
     </details>
   <% end %>
 
+  <% if @skipped_school_moves.present? %>
+    <h3 class="nhsuk-u-reading-width">
+      Records not imported - children at schools in other team areas
+    </h3>
+    <p class="nhsuk-hint">
+      This upload included <%= @skipped_school_moves.count > 1 ? "children" : "a child" %> who <%= @skipped_school_moves.count == 1 ? "was" : "were" %> already
+      registered at a school in another team's area. <%= @skipped_school_moves.count == 1 ? "This child remains" : "These children remain" %>
+      at their current school.
+    </p>
+    <details class="nhsuk-details nhsuk-expander">
+      <summary class="nhsuk-details__summary" data-module="app-sticky">
+        <span class="nhsuk-details__summary-text">
+          <%= pluralize(@skipped_school_moves.count, "record") %> not imported
+        </span>
+      </summary>
+      <div class="nhsuk-details__text">
+        <%= render AppImportReviewRecordsSummaryComponent.new(changesets: @skipped_school_moves) %>
+      </div>
+    </details>
+  <% end %>
+
   <% if @nhs_discrepancies.present? %>
     <h3 class="nhsuk-u-reading-width">
       NHS numbers updated from PDS

spec/features/import_child_records_review_spec.rb

@@ -0,0 +1,120 @@
+# frozen_string_literal: true
+
+describe "Import child records review" do
+  around { |example| travel_to(Date.new(2023, 5, 20)) { example.run } }
+
+  scenario "Skips moving child from another team to unknown school" do
+    given_i_am_signed_in
+    and_two_teams_exist
+    and_import_review_is_enabled
+    and_a_patient_exists_in_another_teams_school
+
+    when_i_visit_the_import_page
+    and_i_choose_to_import_child_records
+    and_i_upload_a_file_moving_child_to_unknown_school
+    then_i_should_see_the_import_review_page
+    and_i_should_see_the_skipped_school_moves_summary
+
+    when_i_approve_the_import
+    then_the_import_should_be_complete
+    and_i_should_see_the_skipped_school_moves_summary
+    and_the_patient_should_remain_at_their_current_school
+    and_the_patient_should_not_be_linked_to_my_team
+  end
+
+  def given_i_am_signed_in
+    programmes = [Programme.hpv, Programme.menacwy, Programme.td_ipv]
+    @team = create(:team, :with_generic_clinic, :with_one_nurse, programmes:)
+    @user = @team.users.first
+
+    # Create a school in this team (children can be uploaded here)
+    create(:school, urn: "123456", team: @team)
+
+    sign_in @user
+  end
+
+  def and_two_teams_exist
+    programmes = [Programme.hpv, Programme.menacwy, Programme.td_ipv]
+    @other_team =
+      create(:team, :with_one_nurse, programmes:, name: "Other Team")
+    @other_school =
+      create(
+        :school,
+        urn: "111222",
+        name: "Other Team School",
+        team: @other_team
+      )
+  end
+
+  def and_import_review_is_enabled
+    Flipper.enable(:import_review_screen)
+  end
+
+  def and_a_patient_exists_in_another_teams_school
+    @patient =
+      create(
+        :patient,
+        given_name: "Mark",
+        family_name: "Doe",
+        nhs_number: nil,
+        date_of_birth: Date.new(2010, 1, 3),
+        address_postcode: "SW1A 1AA",
+        school: @other_school
+      )
+
+    create(
+      :patient_location,
+      patient: @patient,
+      location: @other_school,
+      academic_year: AcademicYear.current
+    )
+  end
+
+  def when_i_visit_the_import_page
+    visit "/dashboard"
+    click_on "Import", match: :first
+  end
+
+  def and_i_choose_to_import_child_records
+    click_on "Upload records"
+    choose "Child records"
+    click_on "Continue"
+  end
+
+  def and_i_upload_a_file_moving_child_to_unknown_school
+    attach_file_fixture "cohort_import[csv]",
+                        "cohort_import/valid_unknown_school.csv"
+    click_on "Continue"
+    wait_for_import_to_complete_until_review(CohortImport)
+  end
+
+  def then_i_should_see_the_import_review_page
+    page.refresh
+    click_on_most_recent_import(CohortImport)
+    expect(page).to have_content("Review and approve")
+  end
+
+  def and_i_should_see_the_skipped_school_moves_summary
+    expect(page).to have_content("1 record not imported")
+    expect(page).to have_content("at their current school")
+  end
+
+  def when_i_approve_the_import
+    click_on "Approve and import records"
+    wait_for_import_to_commit(CohortImport)
+  end
+
+  def then_the_import_should_be_complete
+    expect(page).to have_content("Completed")
+  end
+
+  def and_the_patient_should_remain_at_their_current_school
+    @patient.reload
+    expect(@patient.school).to eq(@other_school)
+  end
+
+  def and_the_patient_should_not_be_linked_to_my_team
+    expect(@patient.teams).not_to include(@team)
+    expect(@patient.teams).to contain_exactly(@other_team)
+  end
+end