Refactor set_programme_statuses

To make the approach consistent and less brittle if the status keys
change.

Author: thomasleese

app/controllers/patients_controller.rb

@@ -96,7 +96,8 @@ def set_programme_statuses
         []
       else
         Patient::ProgrammeStatus.statuses.keys -
-          %w[not_eligible needs_consent_follow_up_requested]
+          Patient::ProgrammeStatus::NOT_ELIGIBLE_STATUSES.keys -
+          %w[needs_consent_follow_up_requested]
       end
   end
 

app/controllers/schools/patients_controller.rb

@@ -54,6 +54,7 @@ def index
   def set_programme_statuses
     @programme_statuses =
       Patient::ProgrammeStatus.statuses.keys -
-        %w[not_eligible needs_consent_follow_up_requested]
+        Patient::ProgrammeStatus::NOT_ELIGIBLE_STATUSES.keys -
+        %w[needs_consent_follow_up_requested]
   end
 end

app/controllers/sessions/base_controller.rb

@@ -17,6 +17,7 @@ def set_session
   def set_programme_statuses
     @programme_statuses =
       Patient::ProgrammeStatus.statuses.keys -
-        %w[not_eligible needs_consent_follow_up_requested]
+        Patient::ProgrammeStatus::NOT_ELIGIBLE_STATUSES.keys -
+        %w[needs_consent_follow_up_requested]
   end
 end