Ensure aged-out patients are not counted in schools index

This fixes a bug where the count of children in each school would
include the aged-out children, who are then not shown by default when
you view the list of children in the school.

This was particularly noticeable for the unknown school, where children
are automatically moved there when they age out.

Jira-Issue: MAV-5059

Author: thomasleese

app/controllers/schools_controller.rb

@@ -17,16 +17,14 @@ def index
 
     @pagy, @locations = pagy(locations)
 
+    academic_year = AcademicYear.pending
+
     @patient_count_by_school_id =
       Patient
         .joins(:patient_locations)
-        .where(
-          patient_locations: {
-            location: @locations,
-            academic_year: AcademicYear.pending
-          }
-        )
+        .where(patient_locations: { location: @locations, academic_year: })
         .not_archived(team: current_team)
+        .appear_in_programmes(current_team.programmes, academic_year:)
         .distinct
         .group(:school_id)
         .count

spec/features/schools_spec.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 describe "Schools" do
-  scenario "Filtering on schools and viewing sessions" do
+  scenario "filtering on schools and viewing sessions" do
     given_a_team_exists_with_a_few_schools
     and_i_am_signed_in
 
@@ -29,7 +29,7 @@
     then_i_see_the_secondary_sessions
   end
 
-  scenario "Sending clinic invitations to children in no known school" do
+  scenario "sending clinic invitations to children in no known school" do
     given_a_team_with_no_known_school_children
     and_i_am_signed_in
 
@@ -65,13 +65,16 @@ def given_a_team_exists_with_a_few_schools
     @secondary_patient =
       create(:patient, year_group: 7, session: @secondary_session)
 
-    @patient_in_both_schools = create(:patient, school: @secondary_school)
+    @patient_in_both_schools = create(:patient, session: @secondary_session)
     create(
       :patient_location,
       patient: @patient_in_both_schools,
       session: @primary_session
     )
 
+    @aged_out_patient =
+      create(:patient, year_group: 13, session: @secondary_session)
+
     @nurse = create(:nurse, team: @team)
   end