Conversation
paulrobertlloyd
temporarily deployed
to
mavis-protot-action-lin-icgbed
… links on session overview page
paulrobertlloyd
force-pushed
the
action-links
branch
from
e7c4ae7 to
bc3cb69
Compare
paulrobertlloyd
temporarily deployed
to
mavis-protot-action-lin-icgbed
malross
reviewed
Apr 14, 2026
| {% include "session/_session-vaccinated-summary.njk" %} | ||
| {% endif %} | ||
|
|
||
| {% if not session.isUnplanned and not session.isCompleted %} |
Collaborator
There was a problem hiding this comment.
What was the previous reason for not showing required actions when the session was completed? What changed?
malross
reviewed
Apr 14, 2026
| {% call card({ | ||
| heading: __("session.summary"), | ||
| headingLevel: 3, | ||
| actions: { |
Collaborator
There was a problem hiding this comment.
OK, I'm gonna need to move a new Cancel Session button to here as well (currently sat on a branch, but I'll rebase on this change once merged to main).
malross
reviewed
Apr 14, 2026
malross
approved these changes
Apr 14, 2026
Collaborator
malross
left a comment
malross
left a comment
There was a problem hiding this comment.
All looks good. My comments/questions are just for info / for me to understand context, but the design and code changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buttons are typically used for submitting data or performing an action, whereas links are used to take you to a new page.
As such, we’ve started using the action link component when linking to the start of a journey. This PR uses this component for remaining links that would benefit from this link styling.
It also rearranges links on the session overview page to make ‘Record offline’ and ‘Send clinic invitations’ links more prominent, for example for a completed session: