Amend pre-prod promotion runbook - #202
Merged
Merged
Conversation
steventux
changed the title
Docs mention a cleanup script which may not be present on the VM. They also assume the VM can manage Azure resources which is not the case so the azcmagent disconnect command needs to force local execution.
steventux
force-pushed
the
update-preprod-promotion-doc
branch
from
September 7, 2026 09:45
67a9675 to
326baf4
Compare
steventux
requested review from
carlosmartinez
and
a lite review from Copilot
September 7, 2026 09:45
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Changes are documentation-only and the remaining feedback is minor clarity/consistency improvements with straightforward fixes.
Pull request overview
Updates the “promote VM from pre-prod to prod” deployment runbook to reflect lessons learned during a real promotion, clarifying prerequisites and adjusting the Arc disconnect procedure and verification guidance.
Changes:
- Add a prerequisite to ensure the cleanup script is already present on the VM.
- Update the cleanup step to run the script from
C:\ArcSetup\...rather than a relative repo path. - Adjust Arc disconnect instructions to use a local-only disconnect and simplify verification guidance.
File summaries
| File | Description |
|---|---|
| docs/deployment/runbooks/promote-vm-preprod-to-prod.md | Runbook tweaks for cleanup readiness, Arc disconnect behavior, and verification steps during promotion. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
53
to
+58
| ## Step 2 — Disconnect from the pre-prod Arc subscription | ||
|
|
||
| Still on the VM, elevated: | ||
|
|
||
| ```powershell | ||
| azcmagent disconnect | ||
| azcmagent disconnect --force-local-only |
carlosmartinez
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update pre-prod promotion runbook with things we found did not work when promoting Somerset to production:
azcmagent disconnectdoesn't work without--force-local-onlyoption.Jira link
https://nhsd-jira.digital.nhs.uk/browse/DTOSS-13653
Review notes
Review checklist