PPHA-783: favicon and manifest file#449
Merged
Themitchell merged 1 commit intomainfrom Apr 23, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds site icon assets (favicon + PWA-style icons) and a web manifest, and adjusts the base Jinja layout’s assetPath to align with the new static asset location.
Changes:
- Added
manifest.jsonunder app static, referencing new favicon/app icons. - Added favicon and icon image assets (SVG/ICO/PNG) under
core/static/images/. - Updated
core/jinja2/layout.jinjato setassetPathtoSTATIC_URL.
Reviewed changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lung_cancer_screening/core/static/manifest.json | Adds manifest with icon definitions for the new favicon/app icons. |
| lung_cancer_screening/core/static/images/nhsuk-icon-mask.svg | Adds monochrome SVG mask icon referenced by the manifest. |
| lung_cancer_screening/core/static/images/nhsuk-icon-512.png | Adds 512px PNG icon referenced by the manifest. |
| lung_cancer_screening/core/static/images/nhsuk-icon-192.png | Adds 192px PNG icon referenced by the manifest. |
| lung_cancer_screening/core/static/images/nhsuk-icon-180.png | Adds 180px PNG icon referenced by the manifest. |
| lung_cancer_screening/core/static/images/favicon.svg | Adds SVG favicon referenced by the manifest. |
| lung_cancer_screening/core/static/images/favicon.ico | Adds ICO favicon referenced by the manifest. |
| lung_cancer_screening/core/jinja2/layout.jinja | Updates assetPath base for NHSUK template asset linking. |
| .vscode/settings.json | Adds a few project-specific words to spellchecker configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jamiefalcus
changed the title
jamiefalcus
force-pushed
the
PPHA-783-fav-icon
branch
from
3880b06 to
8920c4f
Compare
|
|
The review app at this URL has been deleted: |
stephhou
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Adding favicon, manifest file and associated images
Why are we making this change?
Making the site more official looking by having a proper favicon