Ppha 765 former smoker navigation#444
Merged
jamiefalcus merged 10 commits intomainfrom Apr 23, 2026
Merged
Conversation
jamiefalcus
force-pushed
the
PPHA-765-former-smoker-navigation
branch
from
df50344 to
eabfb06
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the smoking-history questionnaire navigation so that when a user selects only one tobacco type, the flow skips the “currently smoke” and “total years smoked” questions to avoid repetition.
Changes:
- Route single-tobacco selections from “types” directly to “smoking frequency”, and adjust back-link behavior accordingly.
- Auto-create default
SmokingCurrentResponseandSmokedTotalYearsResponsewhen only one tobacco type is selected. - Update unit tests and cucumber features to reflect the new navigation and derived answers.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lung_cancer_screening/questions/views/types_tobacco_smoking.py | Adds single-selection redirect to smoking frequency. |
| lung_cancer_screening/questions/views/smoking_frequency.py | Adjusts back-link target based on single vs multiple selections. |
| lung_cancer_screening/questions/forms/types_tobacco_smoking_form.py | Creates default smoking-current and smoked-total-years responses for single selection. |
| lung_cancer_screening/questions/tests/unit/views/test_types_tobacco_smoking.py | Adds/updates redirect and derived-duration assertions for single vs multiple types (incl. former smoker). |
| lung_cancer_screening/questions/tests/unit/views/test_smoking_frequency.py | Updates back-link tests for single vs multiple types. |
| lung_cancer_screening/questions/tests/unit/forms/test_types_tobacco_smoking_form.py | Ensures required prerequisite responses exist for new default-response behavior. |
| features/types_tobacco_smoking.feature | Updates journey expectations when toggling between single/multiple types. |
| features/smoking_history.feature | Updates expected answers to reflect derived “total years” behavior. |
| features/smoking_frequency.feature | Updates expected back link destination. |
| features/smoking_current.feature | Adjusts setup to include multiple types where smoking-current remains relevant. |
| features/smoked_total_years.feature | Adjusts setup to include multiple types where smoked-total-years remains relevant. |
| features/questionnaire.feature | Updates expected answers to reflect derived “total years” behavior and removed steps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stephhou
reviewed
Apr 16, 2026
stephhou
reviewed
Apr 16, 2026
jamiefalcus
force-pushed
the
PPHA-765-former-smoker-navigation
branch
from
9c0779b to
2047296
Compare
|
The review app at this URL has been deleted: |
jamiefalcus
force-pushed
the
PPHA-765-former-smoker-navigation
branch
from
4674d6a to
c92cf83
Compare
stephhou
reviewed
Apr 22, 2026
stephhou
reviewed
Apr 22, 2026
stephhou
approved these changes
Apr 22, 2026
jamiefalcus
force-pushed
the
PPHA-765-former-smoker-navigation
branch
from
e5f3898 to
202679a
Compare
|
mrlockstar
pushed a commit
that referenced
this pull request
Apr 29, 2026
# What is the change? Adding the skipping of current and total years smoked for current and former smokers when only selecting one type of tobacco smoked. # Why are we making this change? Prevents the repetition of questions when only one type of tobacco is being smoked by the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the change?
Adding the skipping of current and total years smoked for current and former smokers when only selecting one type of tobacco smoked.
Why are we making this change?
Prevents the repetition of questions when only one type of tobacco is being smoked by the user.